[llvm] r217747 - Introduce the DWARFUnitSection abstraction.

[Chandler Carruth]

On Mon, Sep 15, 2014 at 12:50 AM, Frederic Riss <friss at apple.com> wrote:

> +/// Base class for all DWARFUnitSection classes. This provides the
> +/// functionality common to all unit types.
> +class DWARFUnitSectionBase {
> +public:
> +  /// Returns the Unit that contains the given section offset in the
> +  /// same section this Unit originated from.
> +  virtual DWARFUnit *getUnitForOffset(uint32_t Offset) const = 0;
>

This, through every instantiation of the below template:


> +};
> +
> +/// Concrete instance of DWARFUnitSection, specialized for one Unit type.
> +template<typename UnitType>
> +class DWARFUnitSection : public SmallVector<std::unique_ptr<UnitType>, 1>,
> +                         public DWARFUnitSectionBase {
>

Is causing *massive* spews of warnings. =/

And what is even going on here? Multiple inheritance between a SmallVector
and something else??? This can't really be the right design? I'm very
confused.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140915/5b4caf3e/attachment.html>