[polly] r217508 - [Refactor] Cleanup isl code generation
Johannes Doerfert
doerfert at cs.uni-saarland.de
Sun Sep 14 09:45:15 PDT 2014
Attached a fix for the problem. Could you take a look?
On 09/14, Johannes Doerfert wrote:
> On 09/14, Tobias Grosser wrote:
> > On 10/09/2014 16:50, Johannes Doerfert wrote:
> > >Author: jdoerfert
> > >Date: Wed Sep 10 09:50:23 2014
> > >New Revision: 217508
> > >
> > >URL: http://llvm.org/viewvc/llvm-project?rev=217508&view=rev
> > >Log:
> > >[Refactor] Cleanup isl code generation
> > >
> > >Summary:
> > > + Refactor the runtime check (RTC) build function
> > > + Added helper function to create an PollyIRBuilder
> > > + Change the simplify region function to create not
> > > only unique entry and exit edges but also enfore that
> > > the entry edge is unconditional
> > > + Cleaned the IslCodeGeneration runOnScop function:
> > > - less post-creation changes of the created IR
> > > + Adjusted and added test cases
> > >
> > >Reviewers: grosser, sebpop, simbuerg, dpeixott
> > >
> > >Subscribers: llvm-commits, #polly
> > >
> > >Differential Revision: http://reviews.llvm.org/D5076
> >
> > Hi Johannes,
> >
> > I just realized that our nightly testers have a couple of failing test
> > cases, that started in a run that includes this commit:
> >
> > http://lab.llvm.org:8011/builders/perf-x86_64-penryn-O3-polly/builds/233
> >
> > The following LNT command currently fails:
> >
> > mysandbox/bin/lnt runtest --verbose nt --sandbox nt --cc
> > /home/grosser/build/bin/clang --cxx /home/grosser/build/bin/clang++
> > --without-llvm --test-suite test-suite/ --no-machdep-info pollyperf-O3-polly
> > --multisample=1 --mllvm=-polly --cflag=-Xclang --cflag=-load --cflag=-Xclang
> > --cflag=/home/grosser/build/lib/LLVMPolly.so
> > --only-test=MultiSource/Applications/oggenc
> >
> > , but works if I revert this commit.
> >
> > Could you check if you can reproduce this issue?
> Yes. I',m looking into it right now.
>
> >
> >
> >
> > >
> > >
> > >Added:
> > > polly/trunk/test/Isl/CodeGen/blas_sscal_simplified.ll
> > > polly/trunk/test/Isl/CodeGen/scop_never_executed_runtime_check_location.ll
> > >Modified:
> > > polly/trunk/include/polly/CodeGen/IRBuilder.h
> > > polly/trunk/include/polly/CodeGen/Utils.h
> > > polly/trunk/include/polly/Support/ScopHelper.h
> > > polly/trunk/lib/CodeGen/CodeGeneration.cpp
> > > polly/trunk/lib/CodeGen/IslCodeGeneration.cpp
> > > polly/trunk/lib/CodeGen/Utils.cpp
> > > polly/trunk/lib/Support/ScopHelper.cpp
> > > polly/trunk/test/Isl/CodeGen/multidim_2d_parametric_array_static_loop_bounds.ll
> > > polly/trunk/test/Isl/CodeGen/run-time-condition-with-scev-parameters.ll
> > >
> > >Modified: polly/trunk/include/polly/CodeGen/IRBuilder.h
> > >URL: http://llvm.org/viewvc/llvm-project/polly/trunk/include/polly/CodeGen/IRBuilder.h?rev=217508&r1=217507&r2=217508&view=diff
> > >==============================================================================
> > >--- polly/trunk/include/polly/CodeGen/IRBuilder.h (original)
> > >+++ polly/trunk/include/polly/CodeGen/IRBuilder.h Wed Sep 10 09:50:23 2014
> > >@@ -95,11 +95,16 @@ private:
> > > //
> > > // We currently always name instructions, as the polly test suite currently
> > > // matches for certain names.
> > >-//
> > >-// typedef PollyBuilderInserter<false> IRInserter;
> > >-// typedef llvm::IRBuilder<false, llvm::ConstantFolder, IRInserter>
> > >-// PollyIRBuilder;
> > > typedef PollyBuilderInserter<true> IRInserter;
> > > typedef llvm::IRBuilder<true, llvm::ConstantFolder, IRInserter> PollyIRBuilder;
> > >+
> > >+/// @brief Return an IR builder pointed before the @p BB terminator.
> > >+static inline PollyIRBuilder createPollyIRBuilder(llvm::BasicBlock *BB,
> > >+ LoopAnnotator &LA) {
> > >+ PollyIRBuilder Builder(BB->getContext(), llvm::ConstantFolder(),
> > >+ polly::IRInserter(LA));
> > >+ Builder.SetInsertPoint(BB->getTerminator());
> > >+ return Builder;
> > >+}
> > > }
> > > #endif
> > >
> > >Modified: polly/trunk/include/polly/CodeGen/Utils.h
> > >URL: http://llvm.org/viewvc/llvm-project/polly/trunk/include/polly/CodeGen/Utils.h?rev=217508&r1=217507&r2=217508&view=diff
> > >==============================================================================
> > >--- polly/trunk/include/polly/CodeGen/Utils.h (original)
> > >+++ polly/trunk/include/polly/CodeGen/Utils.h Wed Sep 10 09:50:23 2014
> > >@@ -15,6 +15,7 @@
> > >
> > > namespace llvm {
> > > class Pass;
> > >+class Value;
> > > class BasicBlock;
> > > }
> > >
> > >@@ -22,16 +23,12 @@ namespace polly {
> > >
> > > class Scop;
> > >
> > >-/// @brief Execute a Scop conditionally.
> > >+/// @brief Execute a Scop conditionally wrt @p RTC.
> > > ///
> > > /// In the CFG the optimized code of the Scop is generated next to the
> > > /// original code. Both the new and the original version of the code remain
> > >-/// in the CFG. A branch statement decides which version is executed.
> > >-/// For now, we always execute the new version (the old one is dead code
> > >-/// eliminated by the cleanup passes). In the future we may decide to execute
> > >-/// the new version only if certain run time checks succeed. This will be
> > >-/// useful to support constructs for which we cannot prove all assumptions at
> > >-/// compile time.
> > >+/// in the CFG. A branch statement decides which version is executed based on
> > >+/// the runtime value of @p RTC.
> > > ///
> > > /// Before transformation:
> > > ///
> > >@@ -53,9 +50,12 @@ class Scop;
> > > /// \ /
> > > /// bb1 (joinBlock)
> > > ///
> > >-/// @param S The Scop to execute conditionally.
> > >-/// @param PassInfo A reference to the pass calling this function.
> > >-/// @return BasicBlock The 'StartBlock' to which new code can be added.
> > >-llvm::BasicBlock *executeScopConditionally(Scop &S, llvm::Pass *PassInfo);
> > >+/// @param S The Scop to execute conditionally.
> > >+/// @param P A reference to the pass calling this function.
> > >+/// @param RTC The runtime condition checked before executing the new SCoP.
> > >+///
> > >+/// @return The 'StartBlock' to which new code can be added.
> > >+llvm::BasicBlock *executeScopConditionally(Scop &S, llvm::Pass *P,
> > >+ llvm::Value *RTC);
> > > }
> > > #endif
> > >
> > >Modified: polly/trunk/include/polly/Support/ScopHelper.h
> > >URL: http://llvm.org/viewvc/llvm-project/polly/trunk/include/polly/Support/ScopHelper.h?rev=217508&r1=217507&r2=217508&view=diff
> > >==============================================================================
> > >--- polly/trunk/include/polly/Support/ScopHelper.h (original)
> > >+++ polly/trunk/include/polly/Support/ScopHelper.h Wed Sep 10 09:50:23 2014
> > >@@ -52,13 +52,14 @@ bool hasInvokeEdge(const llvm::PHINode *
> > > llvm::Value *getPointerOperand(llvm::Instruction &Inst);
> > > llvm::BasicBlock *createSingleExitEdge(llvm::Region *R, llvm::Pass *P);
> > >
> > >-/// @brief Simplify the region in a scop to have a single entry edge
> > >-/// and a single exit edge.
> > >+/// @brief Simplify the region in a SCoP to have a single unconditional entry
> > >+/// edge and a single exit edge.
> > > ///
> > >-/// @param S The scop that is simplified.
> > >+/// @param S The SCoP that is simplified.
> > > /// @param P The pass that is currently running.
> > > ///
> > >-void simplifyRegion(polly::Scop *S, llvm::Pass *P);
> > >+/// @return The unique entering block for the region.
> > >+llvm::BasicBlock *simplifyRegion(polly::Scop *S, llvm::Pass *P);
> > >
> > > /// @brief Split the entry block of a function to store the newly inserted
> > > /// allocations outside of all Scops.
> > >
> > >Modified: polly/trunk/lib/CodeGen/CodeGeneration.cpp
> > >URL: http://llvm.org/viewvc/llvm-project/polly/trunk/lib/CodeGen/CodeGeneration.cpp?rev=217508&r1=217507&r2=217508&view=diff
> > >==============================================================================
> > >--- polly/trunk/lib/CodeGen/CodeGeneration.cpp (original)
> > >+++ polly/trunk/lib/CodeGen/CodeGeneration.cpp Wed Sep 10 09:50:23 2014
> > >@@ -1045,7 +1045,8 @@ public:
> > >
> > > simplifyRegion(&S, this);
> > >
> > >- BasicBlock *StartBlock = executeScopConditionally(S, this);
> > >+ Value *RTC = ConstantInt::getTrue(S.getSE()->getContext());
> > >+ BasicBlock *StartBlock = executeScopConditionally(S, this, RTC);
> > >
> > > PollyIRBuilder Builder(StartBlock->begin());
> > >
> > >
> > >Modified: polly/trunk/lib/CodeGen/IslCodeGeneration.cpp
> > >URL: http://llvm.org/viewvc/llvm-project/polly/trunk/lib/CodeGen/IslCodeGeneration.cpp?rev=217508&r1=217507&r2=217508&view=diff
> > >==============================================================================
> > >--- polly/trunk/lib/CodeGen/IslCodeGeneration.cpp (original)
> > >+++ polly/trunk/lib/CodeGen/IslCodeGeneration.cpp Wed Sep 10 09:50:23 2014
> > >@@ -566,41 +566,51 @@ public:
> > >
> > > IslCodeGeneration() : ScopPass(ID) {}
> > >
> > >+ /// @name The analysis passes we need to generate code.
> > >+ ///
> > >+ ///{
> > >+ LoopInfo *LI;
> > >+ IslAstInfo *AI;
> > >+ DominatorTree *DT;
> > >+ ScalarEvolution *SE;
> > >+ ///}
> > >+
> > >+ /// @brief The loop annotator to generate llvm.loop metadata.
> > >+ LoopAnnotator Annotator;
> > >+
> > >+ /// @brief Build the runtime condition.
> > >+ ///
> > >+ /// Build the condition that evaluates at run-time to true iff all
> > >+ /// assumptions taken for the SCoP hold, and to false otherwise.
> > >+ ///
> > >+ /// @return A value evaluating to true/false if execution is save/unsafe.
> > >+ Value *buildRTC(PollyIRBuilder &Builder, IslExprBuilder &ExprBuilder) {
> > >+ Builder.SetInsertPoint(Builder.GetInsertBlock()->getTerminator());
> > >+ Value *RTC = ExprBuilder.create(AI->getRunCondition());
> > >+ return Builder.CreateIsNotNull(RTC);
> > >+ }
> > >+
> > > bool runOnScop(Scop &S) {
> > >- LoopInfo &LI = getAnalysis<LoopInfo>();
> > >- IslAstInfo &AstInfo = getAnalysis<IslAstInfo>();
> > >- ScalarEvolution &SE = getAnalysis<ScalarEvolution>();
> > >- DominatorTree &DT = getAnalysis<DominatorTreeWrapperPass>().getDomTree();
> > >+ LI = &getAnalysis<LoopInfo>();
> > >+ AI = &getAnalysis<IslAstInfo>();
> > >+ DT = &getAnalysis<DominatorTreeWrapperPass>().getDomTree();
> > >+ SE = &getAnalysis<ScalarEvolution>();
> > >
> > > assert(!S.getRegion().isTopLevelRegion() &&
> > > "Top level regions are not supported");
> > >
> > >- simplifyRegion(&S, this);
> > >-
> > >- BasicBlock *StartBlock = executeScopConditionally(S, this);
> > >- isl_ast_node *Ast = AstInfo.getAst();
> > >- LoopAnnotator Annotator;
> > >- PollyIRBuilder Builder(StartBlock->getContext(), llvm::ConstantFolder(),
> > >- polly::IRInserter(Annotator));
> > >- Builder.SetInsertPoint(StartBlock->begin());
> > >-
> > >- IslNodeBuilder NodeBuilder(Builder, Annotator, this, LI, SE, DT);
> > >+ BasicBlock *EnteringBB = simplifyRegion(&S, this);
> > >+ PollyIRBuilder Builder = createPollyIRBuilder(EnteringBB, Annotator);
> > >
> > >- Builder.SetInsertPoint(StartBlock->getSinglePredecessor()->begin());
> > >+ IslNodeBuilder NodeBuilder(Builder, Annotator, this, *LI, *SE, *DT);
> > > NodeBuilder.addMemoryAccesses(S);
> > > NodeBuilder.addParameters(S.getContext());
> > >- // Build condition that evaluates at run-time if all assumptions taken
> > >- // for the scop hold. If we detect some assumptions do not hold, the
> > >- // original code is executed.
> > >- Value *V = NodeBuilder.getExprBuilder().create(AstInfo.getRunCondition());
> > >- Value *Zero = ConstantInt::get(V->getType(), 0);
> > >- V = Builder.CreateICmp(CmpInst::ICMP_NE, Zero, V);
> > >- BasicBlock *PrevBB = StartBlock->getUniquePredecessor();
> > >- BranchInst *Branch = dyn_cast<BranchInst>(PrevBB->getTerminator());
> > >- Branch->setCondition(V);
> > >+
> > >+ Value *RTC = buildRTC(Builder, NodeBuilder.getExprBuilder());
> > >+ BasicBlock *StartBlock = executeScopConditionally(S, this, RTC);
> > > Builder.SetInsertPoint(StartBlock->begin());
> > >
> > >- NodeBuilder.create(Ast);
> > >+ NodeBuilder.create(AI->getAst());
> > > return true;
> > > }
> > >
> > >
> > >Modified: polly/trunk/lib/CodeGen/Utils.cpp
> > >URL: http://llvm.org/viewvc/llvm-project/polly/trunk/lib/CodeGen/Utils.cpp?rev=217508&r1=217507&r2=217508&view=diff
> > >==============================================================================
> > >--- polly/trunk/lib/CodeGen/Utils.cpp (original)
> > >+++ polly/trunk/lib/CodeGen/Utils.cpp Wed Sep 10 09:50:23 2014
> > >@@ -20,18 +20,17 @@
> > >
> > > using namespace llvm;
> > >
> > >-BasicBlock *polly::executeScopConditionally(Scop &S, Pass *PassInfo) {
> > >+BasicBlock *polly::executeScopConditionally(Scop &S, Pass *P, Value *RTC) {
> > > BasicBlock *StartBlock, *SplitBlock, *NewBlock;
> > > Region &R = S.getRegion();
> > > PollyIRBuilder Builder(R.getEntry());
> > >- DominatorTree &DT =
> > >- PassInfo->getAnalysis<DominatorTreeWrapperPass>().getDomTree();
> > >- RegionInfo &RI = PassInfo->getAnalysis<RegionInfoPass>().getRegionInfo();
> > >- LoopInfo &LI = PassInfo->getAnalysis<LoopInfo>();
> > >+ DominatorTree &DT = P->getAnalysis<DominatorTreeWrapperPass>().getDomTree();
> > >+ RegionInfo &RI = P->getAnalysis<RegionInfoPass>().getRegionInfo();
> > >+ LoopInfo &LI = P->getAnalysis<LoopInfo>();
> > >
> > > // Split the entry edge of the region and generate a new basic block on this
> > > // edge. This function also updates ScopInfo and RegionInfo.
> > >- NewBlock = SplitEdge(R.getEnteringBlock(), R.getEntry(), PassInfo);
> > >+ NewBlock = SplitEdge(R.getEnteringBlock(), R.getEntry(), P);
> > > if (DT.dominates(R.getEntry(), NewBlock)) {
> > > BasicBlock *OldBlock = R.getEntry();
> > > std::string OldName = OldBlock->getName();
> > >@@ -59,7 +58,7 @@ BasicBlock *polly::executeScopConditiona
> > > StartBlock = BasicBlock::Create(F->getContext(), "polly.start", F);
> > > SplitBlock->getTerminator()->eraseFromParent();
> > > Builder.SetInsertPoint(SplitBlock);
> > >- Builder.CreateCondBr(Builder.getTrue(), StartBlock, R.getEntry());
> > >+ Builder.CreateCondBr(RTC, StartBlock, R.getEntry());
> > > if (Loop *L = LI.getLoopFor(SplitBlock))
> > > L->addBasicBlockToLoop(StartBlock, LI.getBase());
> > > DT.addNewBlock(StartBlock, SplitBlock);
> > >@@ -72,7 +71,7 @@ BasicBlock *polly::executeScopConditiona
> > > // PHI nodes that would complicate life.
> > > MergeBlock = R.getExit();
> > > else {
> > >- MergeBlock = SplitEdge(R.getExitingBlock(), R.getExit(), PassInfo);
> > >+ MergeBlock = SplitEdge(R.getExitingBlock(), R.getExit(), P);
> > > // SplitEdge will never split R.getExit(), as R.getExit() has more than
> > > // one predecessor. Hence, mergeBlock is always a newly generated block.
> > > R.replaceExitRecursive(MergeBlock);
> > >
> > >Modified: polly/trunk/lib/Support/ScopHelper.cpp
> > >URL: http://llvm.org/viewvc/llvm-project/polly/trunk/lib/Support/ScopHelper.cpp?rev=217508&r1=217507&r2=217508&view=diff
> > >==============================================================================
> > >--- polly/trunk/lib/Support/ScopHelper.cpp (original)
> > >+++ polly/trunk/lib/Support/ScopHelper.cpp Wed Sep 10 09:50:23 2014
> > >@@ -86,11 +86,14 @@ BasicBlock *polly::createSingleExitEdge(
> > > return SplitBlockPredecessors(BB, Preds, ".region", P);
> > > }
> > >
> > >-void polly::simplifyRegion(Scop *S, Pass *P) {
> > >+BasicBlock *polly::simplifyRegion(Scop *S, Pass *P) {
> > > Region *R = &S->getRegion();
> > >
> > >+ // The entering block for the region.
> > >+ BasicBlock *EnteringBB = R->getEnteringBlock();
> > >+
> > > // Create single entry edge if the region has multiple entry edges.
> > >- if (!R->getEnteringBlock()) {
> > >+ if (!EnteringBB) {
> > > BasicBlock *OldEntry = R->getEntry();
> > > BasicBlock *NewEntry = SplitBlock(OldEntry, OldEntry->begin(), P);
> > >
> > >@@ -101,6 +104,13 @@ void polly::simplifyRegion(Scop *S, Pass
> > > }
> > >
> > > R->replaceEntryRecursive(NewEntry);
> > >+ EnteringBB = OldEntry;
> > >+ }
> > >+
> > >+ // Create an unconditional entry edge.
> > >+ if (EnteringBB->getTerminator()->getNumSuccessors() != 1) {
> > >+ EnteringBB = SplitEdge(EnteringBB, R->getEntry(), P);
> > >+ EnteringBB->setName("polly.entering.block");
> > > }
> > >
> > > // Create single exit edge if the region has multiple exit edges.
> > >@@ -110,6 +120,8 @@ void polly::simplifyRegion(Scop *S, Pass
> > > for (auto &&SubRegion : *R)
> > > SubRegion->replaceExitRecursive(NewExit);
> > > }
> > >+
> > >+ return EnteringBB;
> > > }
> > >
> > > void polly::splitEntryBlockForAlloca(BasicBlock *EntryBlock, Pass *P) {
> > >
> > >Added: polly/trunk/test/Isl/CodeGen/blas_sscal_simplified.ll
> > >URL: http://llvm.org/viewvc/llvm-project/polly/trunk/test/Isl/CodeGen/blas_sscal_simplified.ll?rev=217508&view=auto
> > >==============================================================================
> > >--- polly/trunk/test/Isl/CodeGen/blas_sscal_simplified.ll (added)
> > >+++ polly/trunk/test/Isl/CodeGen/blas_sscal_simplified.ll Wed Sep 10 09:50:23 2014
> > >@@ -0,0 +1,44 @@
> > >+; RUN: opt %loadPolly -polly-codegen-isl < %s
> > >+;
> > >+; Regression test for a bug in the runtime check generation.
> > >+
> > >+; This was extracted from the blas testcase. It crashed in one
> > >+; part of the runtime check generation at some point. To be
> > >+; precise, we couldn't find a suitable block to put the RTC code in.
> > >+;
> > >+; int sscal(int n, float sa, float *sx) {
> > >+; for(int i=0; i<n; i++, sx++)
> > >+; *sx *= sa;
> > >+; return 0;
> > >+; }
> > >+;
> > >+target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128"
> > >+
> > >+define i32 @sscal(i32 %n, float %sa, float* %sx) {
> > >+entry:
> > >+ br label %entry.split
> > >+
> > >+entry.split: ; preds = %entry
> > >+ %cmp1 = icmp sgt i32 %n, 0
> > >+ br i1 %cmp1, label %for.body.lr.ph, label %for.end
> > >+
> > >+for.body.lr.ph: ; preds = %entry.split
> > >+ %0 = zext i32 %n to i64
> > >+ br label %for.body
> > >+
> > >+for.body: ; preds = %for.body.lr.ph, %for.body
> > >+ %indvar = phi i64 [ 0, %for.body.lr.ph ], [ %indvar.next, %for.body ]
> > >+ %sx.addr.02 = getelementptr float* %sx, i64 %indvar
> > >+ %tmp = load float* %sx.addr.02, align 4
> > >+ %mul = fmul float %tmp, %sa
> > >+ store float %mul, float* %sx.addr.02, align 4
> > >+ %indvar.next = add i64 %indvar, 1
> > >+ %exitcond = icmp ne i64 %indvar.next, %0
> > >+ br i1 %exitcond, label %for.body, label %for.cond.for.end_crit_edge
> > >+
> > >+for.cond.for.end_crit_edge: ; preds = %for.body
> > >+ br label %for.end
> > >+
> > >+for.end: ; preds = %for.cond.for.end_crit_edge, %entry.split
> > >+ ret i32 0
> > >+}
> > >
> > >Modified: polly/trunk/test/Isl/CodeGen/multidim_2d_parametric_array_static_loop_bounds.ll
> > >URL: http://llvm.org/viewvc/llvm-project/polly/trunk/test/Isl/CodeGen/multidim_2d_parametric_array_static_loop_bounds.ll?rev=217508&r1=217507&r2=217508&view=diff
> > >==============================================================================
> > >--- polly/trunk/test/Isl/CodeGen/multidim_2d_parametric_array_static_loop_bounds.ll (original)
> > >+++ polly/trunk/test/Isl/CodeGen/multidim_2d_parametric_array_static_loop_bounds.ll Wed Sep 10 09:50:23 2014
> > >@@ -9,11 +9,12 @@ target triple = "x86_64-unknown-linux-gn
> > > ; for (long j = 0; j < 150; j++)
> > > ; A[i][j] = 1.0;
> > > ; }
> > >-
> > >-; CHECK: polly.split_new_and_old:
> > >+;
> > >+; CHECK: entry:
> > > ; CHECK: %0 = icmp sge i64 %m, 150
> > > ; CHECK: %1 = select i1 %0, i64 1, i64 0
> > >-; CHECK: %2 = icmp ne i64 0, %1
> > >+; CHECK: %2 = icmp ne i64 %1, 0
> > >+; CHECK: polly.split_new_and_old:
> > > ; CHECK: br i1 %2, label %polly.start, label %for.i
> > >
> > > define void @foo(i64 %n, i64 %m, double* %A) {
> > >
> > >Modified: polly/trunk/test/Isl/CodeGen/run-time-condition-with-scev-parameters.ll
> > >URL: http://llvm.org/viewvc/llvm-project/polly/trunk/test/Isl/CodeGen/run-time-condition-with-scev-parameters.ll?rev=217508&r1=217507&r2=217508&view=diff
> > >==============================================================================
> > >--- polly/trunk/test/Isl/CodeGen/run-time-condition-with-scev-parameters.ll (original)
> > >+++ polly/trunk/test/Isl/CodeGen/run-time-condition-with-scev-parameters.ll Wed Sep 10 09:50:23 2014
> > >@@ -4,7 +4,7 @@
> > > ; CHECK: %1 = zext i32 %n to i64
> > > ; CHECK: %2 = icmp sge i64 %1, 1
> > > ; CHECK: %3 = select i1 %2, i64 1, i64 0
> > >-; CHECK: %4 = icmp ne i64 0, %3
> > >+; CHECK: %4 = icmp ne i64 %3, 0
> > >
> > > target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128"
> > > target triple = "x86_64-unknown-linux-gnu"
> > >
> > >Added: polly/trunk/test/Isl/CodeGen/scop_never_executed_runtime_check_location.ll
> > >URL: http://llvm.org/viewvc/llvm-project/polly/trunk/test/Isl/CodeGen/scop_never_executed_runtime_check_location.ll?rev=217508&view=auto
> > >==============================================================================
> > >--- polly/trunk/test/Isl/CodeGen/scop_never_executed_runtime_check_location.ll (added)
> > >+++ polly/trunk/test/Isl/CodeGen/scop_never_executed_runtime_check_location.ll Wed Sep 10 09:50:23 2014
> > >@@ -0,0 +1,35 @@
> > >+; RUN: opt %loadPolly -polly-codegen-isl -S -polly-delinearize < %s | FileCheck %s
> > >+; RUN: opt %loadPolly -polly-codegen-isl -S -polly-delinearize -polly-codegen-scev < %s | FileCheck %s
> > >+
> > >+; Verify that we generate the runtime check code after the conditional branch
> > >+; in the SCoP region entering block (here %entry).
> > >+;
> > >+; CHECK: entry:
> > >+; CHECK: zext i32 %n to i64
> > >+; CHECK: br i1 false
> > >+;
> > >+; CHECK: %[[T0:[._a-zA-Z0-9]]] = zext i32 %n to i64
> > >+; CHECK: %[[T1:[._a-zA-Z0-9]]] = icmp sge i64 %[[T0]], 1
> > >+; CHECK: %[[T2:[._a-zA-Z0-9]]] = select i1 %[[T1]], i64 1, i64 0
> > >+; CHECK: %[[T3:[._a-zA-Z0-9]]] = icmp ne i64 %[[T2]], 0
> > >+
> > >+target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128"
> > >+target triple = "x86_64-unknown-linux-gnu"
> > >+
> > >+define void @init_array(i32 %n, double* %data) {
> > >+entry:
> > >+ %0 = zext i32 %n to i64
> > >+ br i1 false, label %for.end10, label %for.body4
> > >+
> > >+for.body4: ; preds = %for.body4, %entry
> > >+ %indvar1 = phi i64 [ %indvar.next2, %for.body4 ], [ 0, %entry ]
> > >+ %.moved.to.for.body4 = mul i64 %0, %indvar1
> > >+ %1 = add i64 %.moved.to.for.body4, 0
> > >+ %arrayidx7 = getelementptr double* %data, i64 %1
> > >+ store double undef, double* %arrayidx7, align 8
> > >+ %indvar.next2 = add i64 %indvar1, 1
> > >+ br i1 false, label %for.body4, label %for.end10
> > >+
> > >+for.end10: ; preds = %for.body4
> > >+ ret void
> > >+}
> > >
> > >
> > >_______________________________________________
> > >llvm-commits mailing list
> > >llvm-commits at cs.uiuc.edu
> > >http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
> > >
> >
>
> --
>
> Johannes Doerfert
> Researcher / PhD Student
>
> Compiler Design Lab (Prof. Hack)
> Saarland University, Computer Science
> Building E1.3, Room 4.26
>
> Tel. +49 (0)681 302-57521 : doerfert at cs.uni-saarland.de
> Fax. +49 (0)681 302-3065 : http://www.cdl.uni-saarland.de/people/doerfert
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
--
Johannes Doerfert
Researcher / PhD Student
Compiler Design Lab (Prof. Hack)
Saarland University, Computer Science
Building E1.3, Room 4.26
Tel. +49 (0)681 302-57521 : doerfert at cs.uni-saarland.de
Fax. +49 (0)681 302-3065 : http://www.cdl.uni-saarland.de/people/doerfert
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Fix-Rewire-the-Region-after-a-unconditional-entry-ed.patch
Type: text/x-diff
Size: 3088 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140914/3c21ba91/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 213 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140914/3c21ba91/attachment.sig>
More information about the llvm-commits
mailing list