[PATCH] Rename getNoopForMachoTarget to getNoop

Joerg Sonnenberger joerg at britannica.bec.de
Sun Sep 14 06:00:42 PDT 2014


On Sat, Sep 13, 2014 at 06:39:04PM -0400, Brad Smith wrote:
> On 13/09/14 5:43 PM, Brad Smith wrote:
> >On 13/09/14 5:20 PM, Joerg Sonnenberger wrote:
> >>On Sat, Sep 13, 2014 at 01:22:58PM -0400, Brad Smith wrote:
> >>>Here is a patch to rename getNoopForMachoTarget to getNoop.
> >>
> >>If we want to keep it like that, it should be abstract to make sure
> >>every target implements it.
> >
> >That is already the case as it is.
> 
> To clarify... every target has to implement it as it is already.

But the existance of the inline default means that we don't find
platforms not implementing it until runtime. Given that we are pretty
much settled on MC now, that seems like an unneecessary pitfall.

Joerg



More information about the llvm-commits mailing list