[PATCH] Move llvm.loop metadata in SplitCriticalEdge

[Tobias Grosser]

On 13/09/2014 20:24, Johannes Doerfert wrote:
>    We will now move llvm.loop metadata (if present) from the old
>    branch instruction to the new one. This will ensure loop id's
>    are not invalidated.
>
> http://reviews.llvm.org/D5344
>
> Files:
>    lib/Transforms/Utils/BreakCriticalEdges.cpp
>    test/Bitcode/break-critical-edges-loop-metadata.ll

Hi Johannes,

I think this is conceptually correct and a good change.

Two minor remarks:

- Is there a need for two loops in this test case?

If not, it would be good to make it as minimal as possible.

- Why do you put the testcase in test/Bitcode?

To my understanding this directory is mostly to test Bitcode parsing and 
writing.

It seems there are not really any test cases yet for this pass, but
you can probably put this one into test/Transforms/Util.

Cheers,
Tobias