[PATCH] Add DIBuilder functions to build RAUWable DIVariables and DIFunctions.

[David Blaikie]

================
Comment at: lib/IR/DIBuilder.cpp:1062
@@ -1035,3 +1061,3 @@
     ConstantInt::get(Type::getInt32Ty(VMContext), isLocalToUnit),
     ConstantInt::get(Type::getInt32Ty(VMContext), 1), /* isDefinition*/
     Val,
----------------
Should this be hardcoded as a definition? Seems like the "createTempStaticVariableFwdDecl" would want a declaration, not a definition.

================
Comment at: lib/IR/DIBuilder.cpp:1196
@@ +1195,3 @@
+                                     unsigned LineNo, DICompositeType Ty,
+                                     bool isLocalToUnit, bool isDefinition,
+                                     unsigned ScopeLine, unsigned Flags,
----------------
Should this take "isDefinition"? The function name indicates that it's only a declaration.

================
Comment at: lib/IR/DIBuilder.cpp:1240
@@ +1239,3 @@
+
+  if (Temporary)
+    Node = MDNode::getTemporary(VMContext, Elts);
----------------
Wonder if there's a nicer way to do this - templated & pass in a lambda?

But it's nothing drastic either way.

http://reviews.llvm.org/D5328