[PATCH] Add threshold for lowering lattice value 'overdefined' in LVI

Joerg Sonnenberger joerg at NetBSD.org
Fri Sep 12 01:12:22 PDT 2014


================
Comment at: lib/Analysis/LazyValueInfo.cpp:41
@@ -39,1 +40,3 @@
 
+// This threshold is purticularly tuned with some special cases exposing
+// regression of compile time and memory consumption.
----------------
Typo. Maybe with the changes suggsted by Hal use just:

// Experimentally derived threshold for additional lowering lattice values per block

================
Comment at: lib/Analysis/LazyValueInfo.cpp:556
@@ -542,1 +555,3 @@
+  // complexity. Therefore, we introduce OverdefinedThreshold to control
+  // the maximum times of further lowering lattice value 'overdefined'.
 
----------------
Maybe just:

// Limit the number of additional lowering lattice value to avoid unjustified memory grows.

http://reviews.llvm.org/D5322






More information about the llvm-commits mailing list