[PATCH] Add -bare option to llvm-objdump

Steve King steve at metrokings.com
Thu Sep 11 09:41:12 PDT 2014


On Thu, Sep 11, 2014 at 7:03 AM, Rafael EspĂ­ndola
<rafael.espindola at gmail.com> wrote:
>
>>> What is your goal?
>
>>A symbolizing disassembler with at least the possibility to tune output to match existing norms per host platform.
>
> We should probably evaluate this on a case by case basis. On the
> particular case of symbolization, I think the main questions are
>
> * In which platforms symbolization is not the default for objdump -d.


None that I know of.


> * What option is used to enable/disable it?

Symbolization is the default, -bare turns it off.


Another point about -bare and diagnostic tests:  scripted checking for
expected output is a different circumstance than human eyeballs
looking at disassembly.  Scripted checking can break when we make
human friendly aesthetic improvements to the output.  Cleaning up
these character mismatches each time doesn't improve test coverage,
but definitely creates more work.

That said, I'm ready to back off on this idea of per-platform defaults
if it's not acceptable to you and Sean.  If you're asking me to comb
through and alter a large number of diag tests as a precursor to any
symbolizing work, I'll have to sleep on it and let you know.  As we
make incremental output improvements, some tests will break
repeatedly.  Maybe somebody else could take on this part?  -bare at
least solves this problem efficiently, so we can get symbolizing
working.

Cheers guys,
-steve




More information about the llvm-commits mailing list