[PATCH 8/8] R600: Add cmpxchg instruction for evergreen

[Matt Arsenault]

On Sep 10, 2014, at 11:11 PM, Aaron Watry <awatry at gmail.com> wrote:

> On Wed, Sep 10, 2014 at 1:24 PM, Matt Arsenault <arsenm2 at gmail.com> wrote:
>> 
>> On Sep 9, 2014, at 6:06 PM, Aaron Watry <awatry at gmail.com> wrote:
>> 
>> 
>> -      if (!MRI.use_empty(MI->getOperand(DstIdx).getReg()))
>> +      if (!MRI.use_empty(MI->getOperand(DstIdx).getReg()) ||
>> MI->getOpcode() == AMDGPU::LDS_CMPST_RET)
>>        return BB;
>> 
>> 
>> These all LGTM, except this checking for a specific opcode looks hacky. This
>> at least should have a FIXME comment about why it’s here
> 
> How about something along the lines of:
> /* FIXME: getLDSNoRetOp method only handles LDS_1A1D LDS ops. Add
> LDS_1A2D support and remove this special case.  */
> 
> --Aaron

Sure, that sounds fine