[patch] Add doInitialization/doFinalization to DataLayoutPass

Chandler Carruth chandlerc at google.com
Wed Sep 10 14:09:41 PDT 2014


LGTM

On Wed, Sep 10, 2014 at 12:34 PM, Rafael EspĂ­ndola <
rafael.espindola at gmail.com> wrote:

> Dmitri noticed that in r202168 doFinalization got dropped from the
> DataLayoutPass.
>
> If we are going to add it back, it is probably a good idea to add
> doInitialization too. With that a DataLayoutPass can be reused for
> multiple modules.
>
> Once we have doInitialization/doFinalization, it doesn't seem
> necessary to pass a Module to the constructor.
>
> Overall this change seems in line with the idea of making DataLayout a
> required part of Module. With it the only way of having a DataLayout
> used is to add it to the Module.
>
> Cheers,
> Rafael
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140910/01165caf/attachment.html>


More information about the llvm-commits mailing list