[PATCH] Add -bare option to llvm-objdump

Sean Silva chisophugis at gmail.com
Wed Sep 10 11:58:40 PDT 2014


> 3. Change disassembly tests to use -d consistently, instead of a random mix of -d, -disassemble, --disassemble

Please make this a separate patch.

================
Comment at: test/tools/llvm-objdump/ARM/macho-mcpu-arm.test:1
@@ -1,2 +1,2 @@
-@ RUN: llvm-mc < %s -triple thumbv7-apple-darwin -mcpu=cortex-a7 -filetype=obj | llvm-objdump -triple thumbv7-apple-darwin10 -m -d -mcpu=cortex-a7 - | FileCheck %s
+@ RUN: llvm-mc < %s -triple thumbv7-apple-darwin -mcpu=cortex-a7 -filetype=obj | llvm-objdump -triple thumbv7-apple-darwin10 -m -bare -d -mcpu=cortex-a7 - | FileCheck %s
 
----------------
What's the harm of running all these tests without -bare? Seems like this patch is creating a lot of churn for no good reason. It would be better to update the tests to use the more readable non-bare output, no? That's what all future tests will be using since not-bare is going to be the default.

================
Comment at: tools/llvm-objdump/llvm-objdump.cpp:89-93
@@ -88,5 +88,7 @@
 
-cl::opt<std::string>
-llvm::TripleName("triple", cl::desc("Target triple to disassemble for, "
-                                    "see -version for available targets"));
+cl::list<std::string>
+llvm::MAttrs("mattr",
+  cl::CommaSeparated,
+  cl::desc("Target specific attributes"),
+  cl::value_desc("a1,+a2,-a3,..."));
 
----------------
Why are you moving all this stuff around? Please put that in a separate patch.

http://reviews.llvm.org/D5279






More information about the llvm-commits mailing list