[PATCH] [asan-assembly-instrumentation] Added end-to-end test for proper stack unwind for functions with inline assembly.

Evgeniy Stepanov eugenis at google.com
Wed Sep 10 02:14:16 PDT 2014


LGTM, thanks

================
Comment at: test/asan/TestCases/Linux/asan-asm-stacktrace-test.cc:14
@@ +13,3 @@
+
+int __attribute__((noinline)) foo(size_t n, int *buffer) {
+  int r;
----------------
I think attributes are usually placed before the return type.

http://reviews.llvm.org/D5260






More information about the llvm-commits mailing list