[PATCH] Add a UnitKind field to DWARFUnit so that we can discriminate the unit's origin section.

Frédéric Riss friss at apple.com
Wed Sep 10 00:38:53 PDT 2014


> On 09 Sep 2014, at 23:36, Adrian Prantl <aprantl at apple.com> wrote:
> 
> I assume that there will be cross-unit reference testcase for llvm-dwarfdump in a subsequent patch that will exercise this code?
> Otherwise this looks simple enough.

Yes, a bunch of tests generating LTO debug info assert once we introduce DW_AT_(specifiaction|abstract_origin) resolving in dwarfdump without this. It’s not the next patch (which only introduces the generic DWARFContext::getUnitForOffset() using this discriminator), but it’s there.

Fred



More information about the llvm-commits mailing list