[PATCH][MIPS] Add aliases for sync instruction used by Octeon CPU

Kai Nacke kai.nacke at redstar.de
Tue Sep 9 23:22:15 PDT 2014


Hi Daniel,

I checked binutils 2.24 and these instructions are indeed not in 
upstream gas. They are in latest Cavium SDK (version 3.1).
I think we should not add them as long as they are not available 
upstream, too.

Committed as r217477 without syncio/syncioall.

Regards,
Kai

On 09.09.2014 11:55, Daniel Sanders wrote:
> The patch LGTM but I'm not sure we should add syncio and syncioall. They don't seem to be in the upstream gas and I found this when I tried searching for them:
> 	SYNCIO and SYNCIOALL opcodes were removed from the assembler.  These were experimental Octeon-specific instructions that are not supported by any Octeon processors.
> 	- https://github.com/zerix/Cavium-SDK-2.0/blob/master/release-notes.txt
> I'm thinking that we shouldn't add them if they've already been removed from the Cavium SDK and never made it upstream. What's your opinion?
>
>> -----Original Message-----
>> From: Kai Nacke [mailto:kai.nacke at redstar.de]
>> Sent: 08 September 2014 06:31
>> To: Daniel Sanders; llvm-commits
>> Subject: Re: [PATCH][MIPS] Add aliases for sync instruction used by Octeon
>> CPU
>>
>> Ping.
>>
>> While checking the Octeon SDK I noticed that gas supports 2 additional
>> aliases: syncio and syncioall. I also added them.
>>
>> Regards,
>> Kai
>>
>> On 02.09.2014 19:05, Kai Nacke wrote:
>>> Hi Daniel,
>>>
>>> the attached patch adds aliases for the sync instruction (synciobdma,
>>> syncs, syncw, syncws) which are used by the Octeon CPU.
>>>
>>> Please review.
>>>
>>> Regards,
>>> Kai
>>>
>>>
>>> _______________________________________________
>>> llvm-commits mailing list
>>> llvm-commits at cs.uiuc.edu
>>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>>
>
>




More information about the llvm-commits mailing list