[PATCH] [PECOFF] Add support for bigobj

David Majnemer david.majnemer at gmail.com
Tue Sep 9 17:42:46 PDT 2014


================
Comment at: lib/ReaderWriter/PECOFF/ReaderCOFF.cpp:364
@@ -367,3 +363,3 @@
     // Cache the name.
-    _symbolName[sym] = name;
+    _symbolName[*sym] = name;
 
----------------
ruiu wrote:
> Is this change valid? It depended on the fact that you can identify a symbol by its address, but I don't think after your change COFFSymbolRef is not guaranteed to be unique for a symbol.
I have COFFSymbolRef an operator< in LLVM.

http://reviews.llvm.org/D5280






More information about the llvm-commits mailing list