[PATCH] Object: Add support for bigobj
Rui Ueyama
ruiu at google.com
Tue Sep 9 14:55:33 PDT 2014
LGTM with this nit.
================
Comment at: include/llvm/Object/COFF.h:248
@@ +247,3 @@
+ return CS16->SectionNumber;
+ return static_cast<int16_t>(CS16->SectionNumber);
+ }
----------------
majnemer wrote:
> ruiu wrote:
> > This needs a comment saying that the reserved section numbers are returned as negative numbers.
> Done.
Where did you add a comment?
http://reviews.llvm.org/D5259
More information about the llvm-commits
mailing list