[PATCH] [AArch64] Enable partial unrolling and runtime unrolling for AArch64 target

[Tilmann Scheller]

Hi,

can we make sure this is enabled only with -O3 rather than -O2/-Os though?
(at least until the code size regressions are fixed)

Regards,

Tilmann

-----Original Message-----
From: llvm-commits-bounces at cs.uiuc.edu
[mailto:llvm-commits-bounces at cs.uiuc.edu] On Behalf Of Renato Golin
Sent: Tuesday, September 09, 2014 3:02 PM
To: James Molloy
Cc: reviews+D5148+public+3607c133967fc2d2 at reviews.llvm.org; LLVM Commits
Subject: Re: [PATCH] [AArch64] Enable partial unrolling and runtime
unrolling for AArch64 target

On 9 September 2014 13:52, James Molloy <james at jamesmolloy.co.uk> wrote:
> The 50% number is code size, not performance. The performance 
> regression is 3.54% for mesa (the largest).

Oh! My bad.

As discussed in the IRC, the performance regressions are on par with the
code size and are not big enough that we should hold on the patch.
If the performance and the code size regressions are both due to inner
loops, than we can fix them with one shot.

Thanks for working on this, and sorry for the noise.

LGTM.

--renato
_______________________________________________
llvm-commits mailing list
llvm-commits at cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits