[PATCH] [make & configure] Don't strip leading underscore on Win64

Anton Korobeynikov anton at korobeynikov.info
Tue Sep 9 03:27:16 PDT 2014


Have you forgot to attach the updated patch? I do not see that something was changed since the original submission.

================
Comment at: tools/llvm-shlib/Makefile:92
@@ +91,3 @@
+ifeq ($(ARCH),x86_64)
+	$(Verb) ($(SED) -n \
+			-e "s/^.* T \([^.][^.]*\)$$/\1/p" \
----------------
loladiro wrote:
> asl wrote:
> > Can we instead of full copy & paste conditionalize the pattern only?
> Sure, any thoughts on how to do that? You can't really put the ifeq inside the command, and using string processing to assemble the command seemed worse to me than this.
Put it outside the command into a variable?

http://reviews.llvm.org/D5036






More information about the llvm-commits mailing list