[llvm] r217398 - llvm-cov: Remove dead code
Justin Bogner
mail at justinbogner.com
Mon Sep 8 12:51:21 PDT 2014
Author: bogner
Date: Mon Sep 8 14:51:21 2014
New Revision: 217398
URL: http://llvm.org/viewvc/llvm-project?rev=217398&view=rev
Log:
llvm-cov: Remove dead code
FunctionCoverageMapping::PrettyName was from a version of the tool
during review, and isn't actually used currently.
Modified:
llvm/trunk/tools/llvm-cov/CodeCoverage.cpp
llvm/trunk/tools/llvm-cov/CoverageFilters.cpp
llvm/trunk/tools/llvm-cov/CoverageSummaryInfo.cpp
llvm/trunk/tools/llvm-cov/FunctionCoverageMapping.h
Modified: llvm/trunk/tools/llvm-cov/CodeCoverage.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-cov/CodeCoverage.cpp?rev=217398&r1=217397&r2=217398&view=diff
==============================================================================
--- llvm/trunk/tools/llvm-cov/CodeCoverage.cpp (original)
+++ llvm/trunk/tools/llvm-cov/CodeCoverage.cpp Mon Sep 8 14:51:21 2014
@@ -368,7 +368,7 @@ bool CodeCoverageTool::createSourceFileV
for (auto Function : InstantiationSet.second) {
auto SubView = llvm::make_unique<SourceCoverageView>(
View, InterestingRange.first, InterestingRange.second,
- Function->PrettyName);
+ Function->Name);
createInstantiationSubView(SourceFile, *Function, *SubView);
View.addChild(std::move(SubView));
}
@@ -417,7 +417,7 @@ bool CodeCoverageTool::load() {
if (Error && !RegionError) {
colored_ostream(errs(), raw_ostream::RED)
<< "error: Regions and counters don't match in a function '"
- << Function.PrettyName << "' (re-run the instrumented binary).";
+ << Function.Name << "' (re-run the instrumented binary).";
errs() << "\n";
RegionError = true;
}
@@ -623,7 +623,7 @@ int CodeCoverageTool::show(int argc, con
Range.second);
createSourceFileView(SourceFile, mainView, Function, true);
ViewOpts.colored_ostream(outs(), raw_ostream::CYAN)
- << Function.PrettyName << " from " << SourceFile << ":";
+ << Function.Name << " from " << SourceFile << ":";
outs() << "\n";
mainView.render(outs());
if (FunctionMappingRecords.size() > 1)
Modified: llvm/trunk/tools/llvm-cov/CoverageFilters.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-cov/CoverageFilters.cpp?rev=217398&r1=217397&r2=217398&view=diff
==============================================================================
--- llvm/trunk/tools/llvm-cov/CoverageFilters.cpp (original)
+++ llvm/trunk/tools/llvm-cov/CoverageFilters.cpp Mon Sep 8 14:51:21 2014
@@ -18,12 +18,12 @@
using namespace llvm;
bool NameCoverageFilter::matches(const FunctionCoverageMapping &Function) {
- StringRef FuncName = Function.PrettyName;
+ StringRef FuncName = Function.Name;
return FuncName.find(Name) != StringRef::npos;
}
bool NameRegexCoverageFilter::matches(const FunctionCoverageMapping &Function) {
- return llvm::Regex(Regex).match(Function.PrettyName);
+ return llvm::Regex(Regex).match(Function.Name);
}
bool RegionCoverageFilter::matches(const FunctionCoverageMapping &Function) {
Modified: llvm/trunk/tools/llvm-cov/CoverageSummaryInfo.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-cov/CoverageSummaryInfo.cpp?rev=217398&r1=217397&r2=217398&view=diff
==============================================================================
--- llvm/trunk/tools/llvm-cov/CoverageSummaryInfo.cpp (original)
+++ llvm/trunk/tools/llvm-cov/CoverageSummaryInfo.cpp Mon Sep 8 14:51:21 2014
@@ -65,7 +65,7 @@ FunctionCoverageSummary::get(const Funct
NumLines += LineCount;
}
return FunctionCoverageSummary(
- Function.PrettyName, RegionCoverageInfo(CoveredRegions, NumCodeRegions),
+ Function.Name, RegionCoverageInfo(CoveredRegions, NumCodeRegions),
LineCoverageInfo(CoveredLines, 0, NumLines));
}
Modified: llvm/trunk/tools/llvm-cov/FunctionCoverageMapping.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-cov/FunctionCoverageMapping.h?rev=217398&r1=217397&r2=217398&view=diff
==============================================================================
--- llvm/trunk/tools/llvm-cov/FunctionCoverageMapping.h (original)
+++ llvm/trunk/tools/llvm-cov/FunctionCoverageMapping.h Mon Sep 8 14:51:21 2014
@@ -35,14 +35,11 @@ struct MappingRegion : public coverage::
struct FunctionCoverageMapping {
/// \brief Raw function name.
std::string Name;
- /// \brief Demangled function name.
- std::string PrettyName;
std::vector<std::string> Filenames;
std::vector<MappingRegion> MappingRegions;
FunctionCoverageMapping(StringRef Name, ArrayRef<StringRef> Filenames)
- : Name(Name), PrettyName(Name),
- Filenames(Filenames.begin(), Filenames.end()) {}
+ : Name(Name), Filenames(Filenames.begin(), Filenames.end()) {}
};
} // namespace llvm
More information about the llvm-commits
mailing list