[PATCH] [Polly][Refactor] Cleanup runtime code generation
David Peixotto
dpeixott at codeaurora.org
Mon Sep 8 10:32:43 PDT 2014
Minor typo. Otherwise the patch looks reasonable to me.
================
Comment at: include/polly/CodeGen/IRBuilder.h:99
@@ -98,3 +98,3 @@
//
// typedef PollyBuilderInserter<false> IRInserter;
// typedef llvm::IRBuilder<false, llvm::ConstantFolder, IRInserter>
----------------
It looks like these comments are just commented out code. Could probably delete them as long as you are cleaning up.
================
Comment at: lib/CodeGen/IslCodeGeneration.cpp:586
@@ +585,3 @@
+ ///
+ /// @return A value evaluating to true/false if execution is save/unsave.
+ Value *buildRTC(PollyIRBuilder &Builder, IslExprBuilder &ExprBuilder) {
----------------
typo save/unsave -> safe/unsafe
http://reviews.llvm.org/D5076
More information about the llvm-commits
mailing list