[PATCH] ARM: Negative offset support problem (bug 20853 fix)

Tim Northover t.p.northover at gmail.com
Mon Sep 8 07:16:55 PDT 2014


Hi Igor,

I've just added the llvm-commits mailing list as a subscriber here. That's where all reviews take place in LLVM (even if we use this to help out).

I think the patch looks mostly fine, but the test is a bit odd: only the first 4 lines of the function actually seem to be tested, so we should either remove the rest or add CHECK lines for them.

Cheers.

Tim.

REPOSITORY
  rL LLVM

http://reviews.llvm.org/D5241






More information about the llvm-commits mailing list