[PATCH] [Polly] Support ModRef function behaviour

Johannes Doerfert doerfert at cs.uni-saarland.de
Mon Sep 8 02:24:59 PDT 2014


1) There is no test case becuase I didn't have the time and idea how to some. We need to check which alias analysis implementations actually annotate the     functions with the "mod-ref-behaviour". I will create test cases once I know there this will go in afterwards.

2) The Scope is basically defined in http://llvm.org/docs/doxygen/html/classllvm_1_1AliasAnalysis.html#ae0276e687a2b2ddd7d0d549d98140f91 to which (without the anchor) I can add a link to the commit message. Basically everything C allows you to do with a pointer (here the argument) is allowed, thus read/write on the whole memory object underneath.

3) I will also address your comments.

================
Comment at: lib/Analysis/TempScopInfo.cpp:290
@@ +289,3 @@
+      WriteBasePtr = dyn_cast<SCEVUnknown>(SE->getPointerBase(WriteAF));
+      assert(WriteBasePtr && "Could not find base pointer");
+      WriteAF = SE->getMinusSCEV(WriteAF, WriteBasePtr);
----------------
grosser wrote:
> Should we not verify this already in the ScopDetection?
Good point, will do.

http://reviews.llvm.org/D5227






More information about the llvm-commits mailing list