[PATCH] ARM Unwind syntax in libcxxabi
Saleem Abdulrasool
compnerd at compnerd.org
Sun Sep 7 11:41:29 PDT 2014
================
Comment at: src/Unwind/UnwindRegistersRestore.S:329
@@ -328,3 +328,3 @@
ldr lr, [lr, #60] @ restore pc into lr
-#if _ARM_ARCH > 4
+#if __ARM_ARCH > 4
bx lr
----------------
Wow. Did this even work previously? This feels like it could be split out into a separate patch to first address use of the branch on ARM v4.
================
Comment at: src/Unwind/UnwindRegistersRestore.S:368
@@ +367,3 @@
+#else
+ vldmia r0, {d0-d15} @ fldmiax is deprecated in ARMv7+ and now behaves like vldmia
+#endif
----------------
Why the comment here but not previously? Im not sure it really adds much. However, I would say that the comment indicating that fldmiax is equivalent to the ldc is more useful and it may be nice to restore those.
http://reviews.llvm.org/D5234
More information about the llvm-commits
mailing list