[llvm] r217292 - [docs] Document what "NFC" means in a commit message.

Sean Silva chisophugis at gmail.com
Fri Sep 5 17:58:51 PDT 2014


The "intended" is implicit. What has caught on is "NFC", so that's what I'm
documenting.

Besides, every commit message has to be implicitly qualified with
"intended" ;)

-- Sean Silva


On Fri, Sep 5, 2014 at 5:56 PM, Chad Rosier <mcrosier at codeaurora.org> wrote:

> Hi Sean,
> Should we add no functional change intended (NFCI) as well?
>
>  Chad
>
> > Author: silvas
> > Date: Fri Sep  5 19:19:16 2014
> > New Revision: 217292
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=217292&view=rev
> > Log:
> > [docs] Document what "NFC" means in a commit message.
> >
> > Modified:
> >     llvm/trunk/docs/Lexicon.rst
> >
> > Modified: llvm/trunk/docs/Lexicon.rst
> > URL:
> >
> http://llvm.org/viewvc/llvm-project/llvm/trunk/docs/Lexicon.rst?rev=217292&r1=217291&r2=217292&view=diff
> >
> ==============================================================================
> > --- llvm/trunk/docs/Lexicon.rst (original)
> > +++ llvm/trunk/docs/Lexicon.rst Fri Sep  5 19:19:16 2014
> > @@ -133,6 +133,15 @@ M
> >  **MC**
> >      Machine Code
> >
> > +N
> > +-
> > +
> > +**NFC**
> > +  "No functional change". Used in a commit message to indicate that a
> > patch
> > +  is a pure refactoring/cleanup.
> > +  Usually used in the first line, so it is visible without opening the
> > +  actual commit email.
> > +
> >  O
> >  -
> >  .. _object pointer:
> >
> >
> > _______________________________________________
> > llvm-commits mailing list
> > llvm-commits at cs.uiuc.edu
> > http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
> >
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140905/10d185ea/attachment.html>


More information about the llvm-commits mailing list