[PATCH] [UBSan] Adding support of MIPS32

Alexey Samsonov vonosmas at gmail.com
Thu Sep 4 12:05:23 PDT 2014


================
Comment at: lib/ubsan/ubsan_handlers.cc:265
@@ -264,3 +264,3 @@
 
-  Diag(getCallerLocation(), DL_Error,
+  Diag(getCallerLocation(Loc), DL_Error,
        "value %0 is outside the range of representable values of type %2")
----------------
Just use Opts.pc instead of Loc here.

================
Comment at: lib/ubsan/ubsan_handlers.cc:273
@@ -272,2 +272,3 @@
   GET_REPORT_OPTIONS(false);
-  handleFloatCastOverflow(Data, From, Opts);
+  uptr Loc=GET_CALLER_PC();
+  handleFloatCastOverflow(Data, Loc, From, Opts);
----------------
kcc wrote:
> please add spaces around '='
You don't need this line, caller's PC is already collected in GET_REPORT_OPTIONS() macro.

http://reviews.llvm.org/D4881






More information about the llvm-commits mailing list