[llvm] r217128 - Add a DWARFContext& member in DWARFUnit.

Frédéric Riss friss at apple.com
Thu Sep 4 00:14:40 PDT 2014


> On 04 Sep 2014, at 08:57, Justin Bogner <mail at justinbogner.com> wrote:
> 
> Frederic Riss <friss at apple.com <mailto:friss at apple.com>> writes:
>> ==============================================================================
>> --- llvm/trunk/lib/DebugInfo/DWARFContext.cpp (original)
>> +++ llvm/trunk/lib/DebugInfo/DWARFContext.cpp Thu Sep  4 01:14:28 2014
>> @@ -318,7 +318,7 @@ void DWARFContext::parseCompileUnits() {
>>   const DataExtractor &DIData = DataExtractor(getInfoSection().Data,
>>                                               isLittleEndian(), 0);
>>   while (DIData.isValidOffset(offset)) {
>> -    std::unique_ptr<DWARFCompileUnit> CU(new DWARFCompileUnit(
>> +    std::unique_ptr<DWARFCompileUnit> CU(new DWARFCompileUnit(*this,
> 
> While you're in here, it might be worthwhile to clean these up to use
> auto and llvm::make_unique.

Like so?

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140904/eb8decdc/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: make_unique.diff
Type: application/octet-stream
Size: 2825 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140904/eb8decdc/attachment.obj>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140904/eb8decdc/attachment-0001.html>


More information about the llvm-commits mailing list