[llvm] r217130 - Rename DWARFContext::getLineTableForCompileUnit to getLineTableForUnit.
Frederic Riss
friss at apple.com
Wed Sep 3 23:14:40 PDT 2014
Author: friss
Date: Thu Sep 4 01:14:40 2014
New Revision: 217130
URL: http://llvm.org/viewvc/llvm-project?rev=217130&view=rev
Log:
Rename DWARFContext::getLineTableForCompileUnit to getLineTableForUnit.
All DWARFUnits can have line information. Rename and change arguments' type
accordingly.
Modified:
llvm/trunk/lib/DebugInfo/DWARFContext.cpp
llvm/trunk/lib/DebugInfo/DWARFContext.h
Modified: llvm/trunk/lib/DebugInfo/DWARFContext.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/DebugInfo/DWARFContext.cpp?rev=217130&r1=217129&r2=217130&view=diff
==============================================================================
--- llvm/trunk/lib/DebugInfo/DWARFContext.cpp (original)
+++ llvm/trunk/lib/DebugInfo/DWARFContext.cpp Thu Sep 4 01:14:40 2014
@@ -291,7 +291,7 @@ const DWARFDebugFrame *DWARFContext::get
}
const DWARFLineTable *
-DWARFContext::getLineTableForCompileUnit(DWARFCompileUnit *cu) {
+DWARFContext::getLineTableForUnit(DWARFUnit *cu) {
if (!Line)
Line.reset(new DWARFDebugLine(&getLineSection().Relocs));
@@ -425,18 +425,18 @@ DWARFCompileUnit *DWARFContext::getCompi
return getCompileUnitForOffset(CUOffset);
}
-static bool getFileNameForCompileUnit(DWARFCompileUnit *CU,
- const DWARFLineTable *LineTable,
- uint64_t FileIndex, FileLineInfoKind Kind,
- std::string &FileName) {
- if (!CU || !LineTable || Kind == FileLineInfoKind::None ||
+static bool getFileNameForUnit(DWARFCompileUnit *U,
+ const DWARFLineTable *LineTable,
+ uint64_t FileIndex, FileLineInfoKind Kind,
+ std::string &FileName) {
+ if (!U || !LineTable || Kind == FileLineInfoKind::None ||
!LineTable->getFileNameByIndex(FileIndex, Kind, FileName))
return false;
if (Kind == FileLineInfoKind::AbsoluteFilePath &&
sys::path::is_relative(FileName)) {
// We may still need to append compilation directory of compile unit.
SmallString<16> AbsolutePath;
- if (const char *CompilationDir = CU->getCompilationDir()) {
+ if (const char *CompilationDir = U->getCompilationDir()) {
sys::path::append(AbsolutePath, CompilationDir);
}
sys::path::append(AbsolutePath, FileName);
@@ -458,8 +458,8 @@ static bool getFileLineInfoForCompileUni
return false;
// Take file number and line/column from the row.
const DWARFDebugLine::Row &Row = LineTable->Rows[RowIndex];
- if (!getFileNameForCompileUnit(CU, LineTable, Row.File, Kind,
- Result.FileName))
+ if (!getFileNameForUnit(CU, LineTable, Row.File, Kind,
+ Result.FileName))
return false;
Result.Line = Row.Line;
Result.Column = Row.Column;
@@ -496,7 +496,7 @@ DILineInfo DWARFContext::getLineInfoForA
return Result;
getFunctionNameForAddress(CU, Address, Spec.FNKind, Result.FunctionName);
if (Spec.FLIKind != FileLineInfoKind::None) {
- const DWARFLineTable *LineTable = getLineTableForCompileUnit(CU);
+ const DWARFLineTable *LineTable = getLineTableForUnit(CU);
getFileLineInfoForCompileUnit(CU, LineTable, Address, Spec.FLIKind, Result);
}
return Result;
@@ -522,7 +522,7 @@ DWARFContext::getLineInfoForAddressRange
return Lines;
}
- const DWARFLineTable *LineTable = getLineTableForCompileUnit(CU);
+ const DWARFLineTable *LineTable = getLineTableForUnit(CU);
// Get the index of row we're looking for in the line table.
std::vector<uint32_t> RowVector;
@@ -533,8 +533,8 @@ DWARFContext::getLineInfoForAddressRange
// Take file number and line/column from the row.
const DWARFDebugLine::Row &Row = LineTable->Rows[RowIndex];
DILineInfo Result;
- getFileNameForCompileUnit(CU, LineTable, Row.File, Spec.FLIKind,
- Result.FileName);
+ getFileNameForUnit(CU, LineTable, Row.File, Spec.FLIKind,
+ Result.FileName);
Result.FunctionName = FunctionName;
Result.Line = Row.Line;
Result.Column = Row.Column;
@@ -561,7 +561,7 @@ DWARFContext::getInliningInfoForAddress(
// try to at least get file/line info from symbol table.
if (Spec.FLIKind != FileLineInfoKind::None) {
DILineInfo Frame;
- LineTable = getLineTableForCompileUnit(CU);
+ LineTable = getLineTableForUnit(CU);
if (getFileLineInfoForCompileUnit(CU, LineTable, Address, Spec.FLIKind,
Frame)) {
InliningInfo.addFrame(Frame);
@@ -582,15 +582,15 @@ DWARFContext::getInliningInfoForAddress(
if (i == 0) {
// For the topmost frame, initialize the line table of this
// compile unit and fetch file/line info from it.
- LineTable = getLineTableForCompileUnit(CU);
+ LineTable = getLineTableForUnit(CU);
// For the topmost routine, get file/line info from line table.
getFileLineInfoForCompileUnit(CU, LineTable, Address, Spec.FLIKind,
Frame);
} else {
// Otherwise, use call file, call line and call column from
// previous DIE in inlined chain.
- getFileNameForCompileUnit(CU, LineTable, CallFile, Spec.FLIKind,
- Frame.FileName);
+ getFileNameForUnit(CU, LineTable, CallFile, Spec.FLIKind,
+ Frame.FileName);
Frame.Line = CallLine;
Frame.Column = CallColumn;
}
Modified: llvm/trunk/lib/DebugInfo/DWARFContext.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/DebugInfo/DWARFContext.h?rev=217130&r1=217129&r2=217130&view=diff
==============================================================================
--- llvm/trunk/lib/DebugInfo/DWARFContext.h (original)
+++ llvm/trunk/lib/DebugInfo/DWARFContext.h Thu Sep 4 01:14:40 2014
@@ -159,8 +159,7 @@ public:
const DWARFDebugFrame *getDebugFrame();
/// Get a pointer to a parsed line table corresponding to a compile unit.
- const DWARFDebugLine::LineTable *
- getLineTableForCompileUnit(DWARFCompileUnit *cu);
+ const DWARFDebugLine::LineTable *getLineTableForUnit(DWARFUnit *cu);
DILineInfo getLineInfoForAddress(uint64_t Address,
DILineInfoSpecifier Specifier = DILineInfoSpecifier()) override;
More information about the llvm-commits
mailing list