[PATCH] Catch malformed inline assembly clobber constraints

Eric Christopher echristo at gmail.com
Wed Sep 3 17:32:59 PDT 2014


The testcase doesn't need either the triple or the data layout for an
llvm-as test.

Also, I tried it, which llvm_unreachable? (I mean, it's obviously doing
something wonky so it's not necessarily a bad patch, but I can't duplicate
whatever problem you're seeing).

-eric




On Wed, Sep 3, 2014 at 1:45 PM, Akira Hatanaka <ahatanak at gmail.com> wrote:

> The attached patch adds a check to InlineAsm::ConstraintInfo::Parse which
> checks that '{' immediately follows '~' in the inline assembly clobber
> constraint. This enables catching the error in the test case earlier by
> LLParser and printing a more helpful diagnostic, rather than terminating
> when an llvm_unreachable is triggered.
>
> This patch fixes rdar://problem/14206559.
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140903/19e6f57f/attachment.html>


More information about the llvm-commits mailing list