Add DWARFFormValue::getAsBlockData(), getAsBlockSize() and getAsFlag().

[Frédéric Riss]

> On 03 Sep 2014, at 20:52, David Blaikie <dblaikie at gmail.com> wrote:
> 
> What's the need for the getAsFlag function?

FC_Flag is a separate class. I just mimicked the other variants. I can however fold FC_Flag into getAsUnsignedConstant(). This would make the followup patch about symbolic constants a tiny bit simpler.

> Perhaps the getAsBlockData/getAsBlockSize could be one function, returning an Optional<ArrayRef<uint8_t*>> ? ("getAsBlock”?)

Great suggestion. I’ll do that and rebase the rest.

Fred

> 
> On Wed, Sep 3, 2014 at 11:47 AM, Frédéric Riss <friss at apple.com <mailto:friss at apple.com>> wrote:
> These new accessors will be used in subsequent patches.
> 
> OK to commit?
> 
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140903/891eca3a/attachment.html>