[llvm] r217005 - Replace printf with outs() <<

Nick Kledzik kledzik at apple.com
Tue Sep 2 18:43:26 PDT 2014


Yes. The bots told me.  I am testing a fix.

-Nick

On Sep 2, 2014, at 6:41 PM, Juergen Ributzka <juergen at apple.com> wrote:
> I think this broke some of the unit test:
> 
> ******************** TEST 'LLVM :: tools/llvm-objdump/macho-exports-trie.test' FAILED ********************
> Script:
> --
> /x/build/trunk/Debug/./bin/llvm-objdump -macho -exports-trie -arch x86_64    /Volumes/Data/src/trunk/llvm/test/tools/llvm-objdump/Inputs/exports-trie.macho-x86_64 2>/dev/null | /x/build/trunk/Debug/./bin/FileCheck /Volumes/Data/src/trunk/llvm/test/tools/llvm-objdump/macho-exports-trie.test
> --
> Exit Code: 1
> 
> Command Output (stderr):
> --
> /Volumes/Data/src/trunk/llvm/test/tools/llvm-objdump/macho-exports-trie.test:7:9: error: expected string not found in input
> # CHECK:0x00000F70 _myWeakweak_def]
>        ^
> <stdin>:7:1: note: scanning from here
> 0x00000F70 _myWeak [weak_def]
> ^
> 
> -Juergen
> 
> On Sep 2, 2014, at 6:12 PM, Nick Kledzik <kledzik at apple.com> wrote:
> 
>> Author: kledzik
>> Date: Tue Sep  2 20:12:52 2014
>> New Revision: 217005
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=217005&view=rev
>> Log:
>> Replace printf with outs() <<
>> 
>> Modified:
>>   llvm/trunk/tools/llvm-objdump/MachODump.cpp
>> 
>> Modified: llvm/trunk/tools/llvm-objdump/MachODump.cpp
>> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-objdump/MachODump.cpp?rev=217005&r1=217004&r2=217005&view=diff
>> ==============================================================================
>> --- llvm/trunk/tools/llvm-objdump/MachODump.cpp (original)
>> +++ llvm/trunk/tools/llvm-objdump/MachODump.cpp Tue Sep  2 20:12:52 2014
>> @@ -1804,7 +1804,7 @@ void llvm::printMachOExportsTrie(const o
>>    outs() << Entry.name();
>>    if (WeakDef || ThreadLocal || Resolver || Abs) {
>>      bool NeedsComma = false;
>> -      printf(" [");
>> +      outs() << " [";
>>      if (WeakDef) {
>>        outs() << "weak_def";
>>        NeedsComma = true;
>> 
>> 
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
> 




More information about the llvm-commits mailing list