[llvm] r216005 - Fix a pair of use after free. Should bring the bots back.
Duncan P. N. Exon Smith
dexonsmith at apple.com
Tue Sep 2 14:18:49 PDT 2014
> On 2014 Sep 2, at 17:15, David Blaikie <dblaikie at gmail.com> wrote:
>
>
>
>
>> On Tue, Sep 2, 2014 at 2:02 PM, Duncan P. N. Exon Smith <dexonsmith at apple.com> wrote:
>> I wonder if we should add a deleted constructor:
>>
>> class StringRef {
>> private:
>> StringRef(std::string &&) LLVM_DELETED;
>> };
>
> unlikely:
>
> std::string src();
> void sink(StringRef);
>
> int main() {
> sink(src());
> }
>
> I imagine there's a reasonable amount of that going on in the codebase - though I could be wrong.
>
I imagine you're right David; I forgot that would match.
More information about the llvm-commits
mailing list