[llvm] r215870 - Revert "Repace SmallPtrSet with SmallPtrSetImpl in function arguments to avoid needing to mention the size."

[Duncan P. N. Exon Smith]

> On 2014 Aug 18, at 17:04, Craig Topper <craig.topper at gmail.com> wrote:
> 
> The failure I got was indicating a double free in an LLVMUsed destructor being called from GlobalOpt.cpp. I reproduced it locally but so far haven't been able to determine why its happening.

I'm working through a backlog (so maybe you've solved this already),
but it looks to me like this might have caused a problem:

static void setUsedInitializer(GlobalVariable &V,
-                               SmallPtrSet<GlobalValue *, 8> Init) {
+                               SmallPtrSetImpl<GlobalValue *> Init) {
  if (Init.empty()) {
    V.eraseFromParent();
    return;

I can't imagine that the SmallPtrSetImpl copy or move constructors
would do anything sane.  They should probably be explicitly deleted.

> On Mon, Aug 18, 2014 at 11:37 AM, Renato Golin <renato.golin at linaro.org> wrote:
> On 18 August 2014 01:24, Craig Topper <craig.topper at gmail.com> wrote:
> > Author: ctopper
> > Date: Sun Aug 17 19:24:38 2014
> > New Revision: 215870
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=215870&view=rev
> > Log:
> > Revert "Repace SmallPtrSet with SmallPtrSetImpl in function arguments to avoid needing to mention the size."
> >
> > Getting a weird buildbot failure that I need to investigate.
> 
> Hi Craig,
> 
> Was it something like this?
> 
> http://lab.llvm.org:8011/builders/clang-native-arm-cortex-a15-self-host/builds/1985/steps/check-all_1/logs/Clang%3A%3Acatch-undef-behavior.cpp
> 
> Maybe I need to clear the build dir in the bot?
> 
> cheers,
> --renato
> 
> 
> 
> -- 
> ~Craig
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits