[PATCH] R600/SI: Fix typos in SIInstrInfo::areLoadsFromSameBasePtr()

Matt Arsenault arsenm2 at gmail.com
Tue Sep 2 11:44:24 PDT 2014


On Sep 2, 2014, at 1:32 PM, Tom Stellard <thomas.stellard at amd.com> wrote:

> This fixes a crash in the OpenCV test:
> ImgprocWarpResizeArea/Resize.Mat/16
> 
> There is no test case for this, because this failure depends on a
> specific ordering of the loads, which could easily change.
> ---
> lib/Target/R600/SIInstrInfo.cpp | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/lib/Target/R600/SIInstrInfo.cpp b/lib/Target/R600/SIInstrInfo.cpp
> index 43efb71..6b8a36b 100644
> --- a/lib/Target/R600/SIInstrInfo.cpp
> +++ b/lib/Target/R600/SIInstrInfo.cpp
> @@ -70,7 +70,7 @@ static bool nodesHaveSameOperandValue(SDNode *N0, SDNode* N1, unsigned OpName) {
>   --Op0Idx;
>   --Op1Idx;
> 
> -  return N0->getOperand(Op0Idx) == N0->getOperand(Op1Idx);
> +  return N0->getOperand(Op0Idx) == N1->getOperand(Op1Idx);
> }
> 
> bool SIInstrInfo::areLoadsFromSameBasePtr(SDNode *Load0, SDNode *Load1,
> @@ -131,7 +131,7 @@ bool SIInstrInfo::areLoadsFromSameBasePtr(SDNode *Load0, SDNode *Load1,
>     if (!nodesHaveSameOperandValue(Load0, Load1, AMDGPU::OpName::soffset) ||
>         findChainOperand(Load0) != findChainOperand(Load1) ||
>         !nodesHaveSameOperandValue(Load0, Load1, AMDGPU::OpName::vaddr) ||
> -        !nodesHaveSameOperandValue(Load1, Load1, AMDGPU::OpName::srsrc))
> +        !nodesHaveSameOperandValue(Load0, Load1, AMDGPU::OpName::srsrc))
>       return false;
> 
>     int OffIdx0 = AMDGPU::getNamedOperandIdx(Opc0, AMDGPU::OpName::offset);
> -- 
> 1.8.5.5
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits

LGTM



More information about the llvm-commits mailing list