[PATCH] Restore the ability to check if LLVMCreateObjectFile was successful

Björn Steinbrink bsteinbr at gmail.com
Mon Sep 1 13:53:17 PDT 2014


Until r216870 LLVMCreateObjectFile returned nullptr in case of an error,
so callers could check if the call was successful. Now, it always
returns an OwningBinary wrapped as an LLVMObjectFileRef, so callers
can't check if the call was successul.

This results in a segfault running e.g.

 llvm-c-test --object-list-sections < /dev/null

So the old behaviour should be restored.

http://reviews.llvm.org/D5143

Files:
  lib/Object/Object.cpp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D5143.13145.patch
Type: text/x-patch
Size: 603 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140901/a026a2aa/attachment.bin>


More information about the llvm-commits mailing list