[PATCH 1/1] build/cmake: Fix CMP0023 warning with libffi

[Jan Vesely]

On Fri, 2014-08-08 at 16:47 -0400, Jan Vesely wrote:
> ping

ping2
did I forget to CC someone?

> anything wrong with this patch?
> 
> On Fri, 2014-07-18 at 11:15 -0400, Jan Vesely wrote:
> > Fixes:
> > CMake Warning (dev) at lib/ExecutionEngine/Interpreter/CMakeLists.txt:16 (target_link_libraries):
> >   Policy CMP0023 is not set: Plain and keyword target_link_libraries
> >   signatures cannot be mixed.  Run "cmake --help-policy CMP0023" for policy
> >   details.  Use the cmake_policy command to set the policy and suppress this
> >   warning.
> > 
> >   The keyword signature for target_link_libraries has already been used with
> >   the target "LLVMInterpreter".  All uses of target_link_libraries with a
> >   target should be either all-keyword or all-plain.
> > 
> >   The uses of the keyword signature are here:
> > 
> >    * cmake/modules/AddLLVM.cmake:345 (target_link_libraries)
> > 
> > Signed-off-by: Jan Vesely <jan.vesely at rutgers.edu>
> > ---
> >  lib/ExecutionEngine/Interpreter/CMakeLists.txt | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/lib/ExecutionEngine/Interpreter/CMakeLists.txt b/lib/ExecutionEngine/Interpreter/CMakeLists.txt
> > index 74df8f0..1aac3ac 100644
> > --- a/lib/ExecutionEngine/Interpreter/CMakeLists.txt
> > +++ b/lib/ExecutionEngine/Interpreter/CMakeLists.txt
> > @@ -13,7 +13,7 @@ add_llvm_library(LLVMInterpreter
> >    )
> >  
> >  if( LLVM_ENABLE_FFI )
> > -  target_link_libraries( LLVMInterpreter ${FFI_LIBRARY_PATH} )
> > +  target_link_libraries( LLVMInterpreter ${cmake_2_8_12_PRIVATE} ${FFI_LIBRARY_PATH} )
> >  endif()
> >  
> >  add_dependencies(LLVMInterpreter intrinsics_gen)
> 

-- 
Jan Vesely <jan.vesely at rutgers.edu>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140901/6a7d8ef3/attachment.sig>