[llvm] r216798 - Comment only: Annotate loop as per mailing list discussion
Jean-Luc Duprat
jduprat at apple.com
Fri Aug 29 15:43:30 PDT 2014
Author: jduprat
Date: Fri Aug 29 17:43:30 2014
New Revision: 216798
URL: http://llvm.org/viewvc/llvm-project?rev=216798&view=rev
Log:
Comment only: Annotate loop as per mailing list discussion
Modified:
llvm/trunk/lib/TableGen/TGParser.cpp
Modified: llvm/trunk/lib/TableGen/TGParser.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/TableGen/TGParser.cpp?rev=216798&r1=216797&r2=216798&view=diff
==============================================================================
--- llvm/trunk/lib/TableGen/TGParser.cpp (original)
+++ llvm/trunk/lib/TableGen/TGParser.cpp Fri Aug 29 17:43:30 2014
@@ -1315,6 +1315,9 @@ Init *TGParser::ParseSimpleValue(Record
// first. We'll first read everything in to a vector, then we can reverse
// it to get the bits in the correct order for the BitsInit value.
for (unsigned i = 0, e = Vals.size(); i != e; ++i) {
+ // FIXME: The following two loops would not be duplicated
+ // if the API was a little more orthogonal.
+
// bits<n> values are allowed to initialize n bits.
if (BitsInit *BI = dyn_cast<BitsInit>(Vals[i])) {
for (unsigned i = 0, e = BI->getNumBits(); i != e; ++i)
More information about the llvm-commits
mailing list