[PATCH] Remove static initializers from MCSchedModel

Andrew Trick atrick at apple.com
Fri Aug 29 14:10:56 PDT 2014


> On Aug 29, 2014, at 9:38 AM, Pete Cooper <peter_cooper at apple.com> wrote:
> 
> Hi all
> 
> Please review this patch to change MCSchedModel to avoid static initializers.  This makes it behavior match other structs with similar uses, e.g., MCWriteProcResEntry and MCProcResourceDesc.
> 
> This is part of the work to remove all the static initializers from LLVM.


Great. I can’t remember why we needed a default ctor on MCSchedModel any more. If we can get away with constant static initialization it’s much better.

I would define an LLVM_DELETED_FUNCTION default ctor to make sure we’re not silently breaking some target.

LGTM.

-Andy



More information about the llvm-commits mailing list