[PATCH] fix a logic bug in x86 vector codegen: sext (zext (x) ) != sext (x) (PR20472)

Nadav Rotem nrotem at apple.com
Thu Aug 28 11:06:46 PDT 2014


LGTM!

Sanjay, you can commit changes like this without waiting for pre-commit code review (See item #3 in http://llvm.org/docs/DeveloperPolicy.html#code-reviews).

Thanks,
Nadav




> On Aug 28, 2014, at 10:48 AM, Sanjay Patel <spatel at rotateright.com> wrote:
> 
> Ping 2.
> 
> This is a miscompile that apparently occurs in the wild. 
> 
> Easy review - the fix doesn't add any lines of code other than comments. :)
> 
> http://reviews.llvm.org/D4909
> 
> 




More information about the llvm-commits mailing list