[PATCH] Verifier: Don't reject varargs callee cleanup functions

Reid Kleckner rnk at google.com
Mon Aug 25 18:42:08 PDT 2014


Hi rafael, nlewycky,

We've rejected these kinds of functions since r28405 in 2006 because
it's impossible to lower the return of a callee cleanup varargs
function. However there are lots of legal ways to leave such a function
without returning, such as aborting. Today we can leave a function with
a musttail call to another function with the correct prototype, and
everything works out.

Therefore I'd like to remove the verifier check just say that a normal
return from such a function is UB.

http://reviews.llvm.org/D5059

Files:
  test/Verifier/musttail-valid.ll
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D5059.12929.patch
Type: text/x-patch
Size: 939 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140826/0d5197d2/attachment.bin>


More information about the llvm-commits mailing list