[PATCH] [Support] Windows - Refactor argument serialization logic when executing process in Program.inc [NFC]

Rafael Ávila de Espíndola rafael.espindola at gmail.com
Mon Aug 25 14:54:11 PDT 2014


LGTM with a check.

================
Comment at: lib/Support/Windows/Program.inc:207
@@ -218,1 +206,3 @@
   *p = 0;
+  return command;
+}
----------------
Don't you need a std::move in here?

http://reviews.llvm.org/D5054






More information about the llvm-commits mailing list