[PATCH] [Support] Fix bug in llvm::sys::argumentsFitWithinSystemLimits() of Unix/Program.inc

Rafael Auler rafaelauler at gmail.com
Mon Aug 25 12:56:45 PDT 2014


Hi rafael,

This patch fixes a subtle bug in the UNIX implementation of llvm::sys::argumentsFitWithinSystemLimits() regarding the misuse of a static variable. This bug causes our cached number that stores the system command line maximum length to be halved after each call to the function. With a sufficient number of calls to this function, it will eventually report any given command line string to be over system limits.

http://reviews.llvm.org/D5053

Files:
  lib/Support/Unix/Program.inc
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D5053.12911.patch
Type: text/x-patch
Size: 608 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140825/00f7a536/attachment.bin>


More information about the llvm-commits mailing list