[llvm] r216170 - Make format_object_base's destructor protected and non-virtual.

[Chandler Carruth]

On Sat, Aug 23, 2014 at 2:58 AM, Patrik Hägglund H <
patrik.h.hagglund at ericsson.com> wrote:

> > In all seriousness, we need to find a solution to this soon, or revert
> this change.
>
>
>
> +1
>
>
>
> > For those who want to use old/pre-installed/official release clangs
> rather than more recent iterations, they can just disable –Werror (it's
> not the default anyway).
>
>
>
> For us, disabling –Werror is currently not an option. If this is the
> intention, I think the policy should be updated first. (I would rather like
> the policy to be strengthened, to support –Werror builds with the latest
> official release of _*both*_ clang and gcc.)
>

While I haven't really had time, and I didn't even write the original
patch, I've already described exactly how to fix this by disabling the
warning with a version check in CMake... It should be really
straightforward to implement. I guess if for some reason none have done it
I will, but I don't even have a version of Clang to test it with, so I'm
somewhat inclined for someone who does to write this patch...
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140823/6ea70a71/attachment.html>