[PATCH] [SROA] Fix for a SROA store widening bug

[Gao, Yunzhong]

Not a big deal. Many thanks for fixing the bug, Reid!
I have a follow-up question on the test case: so the test case added by Reid tests the case where the
store size is smaller than slice size; the test case included in D4933 tests the case where the store size
is bigger than slice size. Do you think there is value in adding this test case to slice-width.ll?


From: Chandler Carruth [mailto:chandlerc at google.com]
Sent: Thursday, August 21, 2014 7:50 PM
To: reviews+D4933+public+26bbaddb914ec8e1 at reviews.llvm.org
Cc: Gao, Yunzhong; Benjamin Kramer; Commit Messages and Patches for LLVM
Subject: Re: [PATCH] [SROA] Fix for a SROA store widening bug

Also, really sorry I missed this patch. =/ Have been struggling to catch up with email after nearly a week away from many things, and Reid poked me sharply when he hit the same issue.

On Thu, Aug 21, 2014 at 7:39 PM, Yunzhong Gao <Yunzhong_Gao at playstation.sony.com<mailto:Yunzhong_Gao at playstation.sony.com>> wrote:
Looks like this test case is just a special case of PR18726, which Reid just fixed in r216248.

http://reviews.llvm.org/D4933



_______________________________________________
llvm-commits mailing list
llvm-commits at cs.uiuc.edu<mailto:llvm-commits at cs.uiuc.edu>
http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140822/0437a1be/attachment.html>