[PATCH] Add writeFileWithSystemEncoding to LibLLVMSupport

Rafael Ávila de Espíndola rafael.espindola at gmail.com
Fri Aug 22 10:42:31 PDT 2014


Only a nit in addition to what Reid noticed. LGTM otherwise.

================
Comment at: include/llvm/Support/Program.h:141
@@ +140,3 @@
+  /// response files that link.exe or gcc.exe will read.
+  /// \returns true if successful, otherwise \p ErrMsg is filled accordingly.
+  bool writeFileWithEncoding(const char *FileName, const char *contents,
----------------
Please include a quick summary of your table. At least say that what requires us to use EM_CurrentCodePage is that gnu tools (ld, and gcc at least) on mingw only work with the current code page.

BTW, have you tested with mingw-w64 too? If they support UTF8 or UTF16 and the old mingw does not that seems like a reason to push for a switch at some point.

http://reviews.llvm.org/D4896






More information about the llvm-commits mailing list