[llvm] r216119 - X86: Align the stack on word boundaries in LowerFormalArguments()

Reid Kleckner rnk at google.com
Thu Aug 21 17:32:09 PDT 2014


Cool! Thanks for the additional test case. It was harder to write, so I
went for the stdcall mangling test case instead. :)


On Thu, Aug 21, 2014 at 4:51 PM, Duncan P. N. Exon Smith <
dexonsmith at apple.com> wrote:

> +tjablin
>
> > On 2014-Aug-21, at 15:42, Reid Kleckner <rnk at google.com> wrote:
> >
> > How was this not handled by r214980?
>
> It was.  Reverted in r216246.
>
> I looked carefully at this on August 4th (before r214980), and when it
> popped back up I didn't check that the testcase still failed.
>
> Thomas: I left your testcase in tree (and it still passes).  Can you
> confirm that r214980 is sufficient?
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140821/9db9dbbd/attachment.html>


More information about the llvm-commits mailing list