[patch] Split parseAssembly in parseAssembly and parseAssemblyInto.

David Blaikie dblaikie at gmail.com
Thu Aug 21 14:11:53 PDT 2014


On Thu, Aug 21, 2014 at 12:51 PM, Rafael EspĂ­ndola
<rafael.espindola at gmail.com> wrote:
>> Ah, OK - if no one's using it, do we need to add it back in?
>
> It is not used in tree, but Keno is using it in Julia. Since it is a
> small change I added it back, but now with hopefully a less confusing
> interface.

Ah, OK - I kind of dislike having untested/dead code & would prefer
such things to be unit tested or someone will just refactor the extra
function away again next week/month/year.

But I'm not too fussed - happy to sign off on this if no one else
cares to stand more firmly on that point.

- David




More information about the llvm-commits mailing list