[llvm] r216170 - Make format_object_base's destructor protected and non-virtual.

[Justin Bogner]

Benjamin Kramer <benny.kra at googlemail.com> writes:
> Author: d0k
> Date: Thu Aug 21 06:22:05 2014
> New Revision: 216170
>
> URL: http://llvm.org/viewvc/llvm-project?rev=216170&view=rev
> Log:
> Make format_object_base's destructor protected and non-virtual.
>
> It's not meant to be used with operator delete and this avoids
> emitting virtual dtors for every derived format object.

This change is obviously for the better, but it triggers a warning when
building with clang 3.4 (and probably every clang back to 2.9 or so),
which is pretty unfortunate.

The problem is, until r208449, we didn't know not to warn about this on
final classes or when the destructor was protected. I'm not entirely
sure what we should do here, but this is likely to break anyone who
builds with -Werror for a while.