[llvm-commits] [compiler-rt] r150083 - in /compiler-rt/trunk/lib/asan: Makefile.mk Makefile.old asan_interceptors.cc asan_interceptors.h asan_mac.cc asan_mac.h asan_malloc_mac.cc interception/ interception/Makefile.mk interception/interception.h interception/interception_linux.cc interception/interception_linux.h interception/interception_mac.cc interception/interception_mac.h

[Timur Iskhodzhanov]

Well, looks like this was just a bug/misunderstanding carried over :)
See r216177 – all the tests pass on the bots to the best of my knowledge.

2014-08-15 19:48 GMT+04:00 Alexey Samsonov <samsonov at google.com>:
>
> On Aug 15, 2014 7:44 AM, "Timur Iskhodzhanov" <timurrrr at google.com> wrote:
>>
>>
>> 2012-02-08 23:52 GMT+04:00 Alexey Samsonov <samsonov at google.com>:
>>>
>>> -  INTERCEPT_FUNCTION(memset);
>>> -  INTERCEPT_FUNCTION(strcasecmp);
>>> -  INTERCEPT_FUNCTION(strcat);  // NOLINT
>>> -  INTERCEPT_FUNCTION(strchr);
>>> -  INTERCEPT_FUNCTION(strcmp);
>>> -  INTERCEPT_FUNCTION(strcpy);  // NOLINT
>>> -  INTERCEPT_FUNCTION(strdup);
>>> -  INTERCEPT_FUNCTION(strlen);
>>> -  INTERCEPT_FUNCTION(strncasecmp);
>>> -  INTERCEPT_FUNCTION(strncmp);
>>> -  INTERCEPT_FUNCTION(strncpy);
>>> -
>>> -  INTERCEPT_FUNCTION(sigaction);
>>> -  INTERCEPT_FUNCTION(signal);
>>> -  INTERCEPT_FUNCTION(longjmp);
>>> -  INTERCEPT_FUNCTION(_longjmp);
>>> -  INTERCEPT_FUNCTION_IF_EXISTS(__cxa_throw);
>>> -  INTERCEPT_FUNCTION(pthread_create);
>>> +  CHECK(INTERCEPT_FUNCTION(memset));
>>> +  CHECK(INTERCEPT_FUNCTION(strcasecmp));
>>> +  CHECK(INTERCEPT_FUNCTION(strcat));  // NOLINT
>>> +  CHECK(INTERCEPT_FUNCTION(strchr));
>>> +  CHECK(INTERCEPT_FUNCTION(strcmp));
>>> +  CHECK(INTERCEPT_FUNCTION(strcpy));  // NOLINT
>>> +  CHECK(INTERCEPT_FUNCTION(strdup));
>>> +  CHECK(INTERCEPT_FUNCTION(strlen));
>>> +  CHECK(INTERCEPT_FUNCTION(strncasecmp));
>>> +  CHECK(INTERCEPT_FUNCTION(strncmp));
>>> +  CHECK(INTERCEPT_FUNCTION(strncpy));
>>> +
>>> +  CHECK(INTERCEPT_FUNCTION(sigaction));
>>> +  CHECK(INTERCEPT_FUNCTION(signal));
>>> +  CHECK(INTERCEPT_FUNCTION(longjmp));
>>> +  CHECK(INTERCEPT_FUNCTION(_longjmp));
>>> +  INTERCEPT_FUNCTION(__cxa_throw);
>>> +  CHECK(INTERCEPT_FUNCTION(pthread_create));
>>
>>
>> Hm, __cxa_throw is different here -- is it intentional?
>> Is it because __cxa_throw may not be there in applications w/o exceptions?
>
> IIRC, yes.