[lld] r216153 - [PECOFF] Don't use default argument.
Rui Ueyama
ruiu at google.com
Wed Aug 20 20:40:33 PDT 2014
Author: ruiu
Date: Wed Aug 20 22:40:33 2014
New Revision: 216153
URL: http://llvm.org/viewvc/llvm-project?rev=216153&view=rev
Log:
[PECOFF] Don't use default argument.
I'm adding new parameters to the function, and the existing
parameter with a default argument is found confusing.
Modified:
lld/trunk/lib/ReaderWriter/PECOFF/IdataPass.cpp
lld/trunk/lib/ReaderWriter/PECOFF/Pass.h
Modified: lld/trunk/lib/ReaderWriter/PECOFF/IdataPass.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/PECOFF/IdataPass.cpp?rev=216153&r1=216152&r2=216153&view=diff
==============================================================================
--- lld/trunk/lib/ReaderWriter/PECOFF/IdataPass.cpp (original)
+++ lld/trunk/lib/ReaderWriter/PECOFF/IdataPass.cpp Wed Aug 20 22:40:33 2014
@@ -104,7 +104,7 @@ std::vector<ImportTableEntryAtom *> Impo
entry = new (_alloc) ImportTableEntryAtom(context, 0, sectionName);
HintNameAtom *hintName =
new (_alloc) HintNameAtom(context, atom->hint(), atom->importName());
- addDir32NBReloc(entry, hintName);
+ addDir32NBReloc(entry, hintName, 0);
}
ret.push_back(entry);
if (shouldAddReference)
Modified: lld/trunk/lib/ReaderWriter/PECOFF/Pass.h
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/PECOFF/Pass.h?rev=216153&r1=216152&r2=216153&view=diff
==============================================================================
--- lld/trunk/lib/ReaderWriter/PECOFF/Pass.h (original)
+++ lld/trunk/lib/ReaderWriter/PECOFF/Pass.h Wed Aug 20 22:40:33 2014
@@ -16,10 +16,10 @@ namespace lld {
namespace pecoff {
void addDir32Reloc(COFFBaseDefinedAtom *atom, const Atom *target,
- size_t offsetInAtom = 0);
+ size_t offsetInAtom);
void addDir32NBReloc(COFFBaseDefinedAtom *atom, const Atom *target,
- size_t offsetInAtom = 0);
+ size_t offsetInAtom);
} // namespace pecoff
} // namespace lld
More information about the llvm-commits
mailing list