[compiler-rt] r215295 - builtins: correct __umodsi3, __udivsi3 on ARM

Anton Korobeynikov anton at korobeynikov.info
Tue Aug 19 14:36:44 PDT 2014


> I agree that __umodsi3 was completely wrong, and I believe this is a
> left-over from an old divmod implementation, as is the __udivsi3.
> Anton would know better, as I believe he wrote the original code.
>
> I'm worried about the bogus write to [r2] as it could really lead to
> memory corruption, but not so much for the udiv.
I do not recall all the details, but I believe the original code (ARM
stuff in compiler-rt) was something written for Darwin. At that time I
reviewed everything and add EABI compatibility bits to ones which
looked suitable...

-- 
With best regards, Anton Korobeynikov
Faculty of Mathematics and Mechanics, Saint Petersburg State University



More information about the llvm-commits mailing list