[PATCH] Relax atomic restrictions on memory dependence analysis

Robin Morisset morisset at google.com
Mon Aug 18 14:43:34 PDT 2014


Answer to Philip Reames comments

- add check for volatile (probably unneeded, but I agree that we should be conservative about it).
- strengthen condition from isUnordered() to isSimple(), as I don't understand well enough Unordered semantics (and it also matches the comment better this way) to be confident in the previous behaviour (thanks a lot for catching that one, I had missed the case Monotonic/Unordered).
- separate a condition in two.
- lengthen comment about aliasing and loads
- add tests in GVN/atomic.ll

http://reviews.llvm.org/D4797

Files:
  lib/Analysis/MemoryDependenceAnalysis.cpp
  test/Transforms/DeadStoreElimination/atomic.ll
  test/Transforms/GVN/atomic.ll
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D4797.12626.patch
Type: text/x-patch
Size: 5159 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140818/96bfd3fb/attachment.bin>


More information about the llvm-commits mailing list